MoneyType Work Item Rss Feed

Commented Issue: Multiply and divide ignore the Currency [3437]

Marchy — Mon, 22 Oct 2012 02:27:50 GMT

operator * and operator / both ignore the Currency of the amount being modified and return a Money for the current culture. Code should be
 
 public static Money operator *(Money left, Decimal right)
 {
 return new Money(((Decimal)left * right), left._currency);
 }
 
 public static Money operator /(Money left, Decimal right)
 {
 return new Money(((Decimal)left / right), left._currency);
 }
 
thanks for prividing this project
Paul
Comments: ** Comment from web user: Marchy **

Agreed, had made the same fix

Created Issue: Money(decimal, Currency) ignores second argument

esteewhy — Fri, 08 May 2009 15:10:59 GMT

Another subtle glitch: when supplying Currency as a second argument to Money ctor, that arg gets overridden. I think it's the order of constructor calls that matters.

Commented Issue: Code (re)usability improvements

esteewhy — Fri, 08 May 2009 13:24:21 GMT

Hello, great work! Found you at CodeProject first, than saw the code here, started using it and found some issues worth mentioning:

-- I'd like to persist Money type as a string in a custom format, so it's desirable to know if a given currency code is valid in the system. For this case to work i've introduced a Currency.TryParse(..) method with a semantic similar to that of some standard CLR value types.

-- For UI purpose it'd be cool to have a list of all valid currencies, so i've exposed it via static Currency.Currencies property

-- Presently, there's no way to know if a given Currency instance represents a valid currency until you try to access any instance property and, possibly, get an InvalidOperationException -- ups, not nice! I've made these properties silently return default values if no matching currency was found. So at least the following snippet won't cause an earthquake: new Currency().IsoNumericCode, but just silently return "0". For the sake of consistency, i've also added Currency.Empty static instance.

-- Finally, just to simplify a bit working with a huge source file, i've moved a part of Currency.cs into partial class file.
Comments: ** Comment from web user: esteewhy **

Ups, also, forgot to tell you: I've also created some helper methods to de/serialise Money to/fro string. Just in case smb. w'd be interested...

Created Issue: Code (re)usability improvements

esteewhy — Fri, 08 May 2009 13:21:37 GMT

Created Issue: Multiply and divide ignore the Currency

PaulLinton — Tue, 24 Mar 2009 00:36:06 GMT

operator * and operator / both ignore the Currency of the amount being modified and return a Money for the current culture. Code should be

public static Money operator *(Money left, Decimal right)
{
return new Money(((Decimal)left * right), left._currency);
}

public static Money operator /(Money left, Decimal right)
{
return new Money(((Decimal)left / right), left._currency);
}

thanks for prividing this project
Paul

Created Issue: Formatting errors

dgon — Mon, 29 Sep 2008 19:42:36 GMT

Hi,
When reviewing your code I found that no matter what currency is set on the Money object, it gets ignored when calling ToString(), being always the currency corresponding the current Culture. If it happens to be a culture with $, then the corresponding test is passed.
I tried fixing it myself, passing the current _currency as the IFormatInfo argument, but then it complains heavily about the code used to create the corresponding cultureInfo as it expect a windows Lcid (not Iso number code).

Thanks a lot if you happen to look at it, great code, by the way